Prevent warnings from new IVTs from Roslyn#11504
Merged
davidwengier merged 1 commit intodotnet:mainfrom Feb 18, 2025
Merged
Conversation
DustinCampbell
approved these changes
Feb 18, 2025
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Does this go away when we move to Roslyn's LSP implementation?
Member
Author
|
No, this is largely extracted from that PR. The issue is we now have IVT to something that references the CLaSP source package, and we reference the CLaSP source package. The only alternative is to not reference CLaSP ourselves and use the one we get from IVT, but then we are seceptible to binary breaks. |
This was referenced Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to dotnet/roslyn#74597 to pave the way for #10682 once Web Tools inserts.
The break from the Roslyn change is not binary breaking, so no need for dual insertion, and since this change doesn't break anything, we can get this in now, and whenever we happen to bump Roslyn next, there should be no build issues.